chahine/rebreak-monorepo
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(magic): use hex for DNS token (AdGuard rejects base64url '_')

Browse Source 
AdGuard validates client IDs as DNS labels: 'invalid clientid: bad
hostname label rune'. base64url alphabet contains '_' which fails.
Switch to hex (a-f, 0-9) — 32 bytes hex = 64 chars, 256-bit entropy,
DNS-safe.
This commit is contained in:
chahinebrini 2026-06-03 09:41:47 +02:00
parent 77edd67cbe
commit 038c383bef
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
backend/server/api/magic/register.post.ts
View File

@ -78,8 +78,10 @@ export default defineEventHandler(async (event) => {
} }
} }
// 3. Generiere DNS-Token (48 char base64url-safe) // 3. Generiere DNS-Token (64 char hex)
const dnsToken = randomBytes(36).toString("base64url"); // WICHTIG: hex statt base64url — AdGuard's clientid muss DNS-Label-konform sein,
// verbietet `_` (das base64url als Ersatz für `/` generiert) → 400 "bad hostname label rune".
const dnsToken = randomBytes(32).toString("hex");
// 4. Provisioniere AdGuard Client // 4. Provisioniere AdGuard Client
const adguardClientName = `magic_${deviceId}`; const adguardClientName = `magic_${deviceId}`;